Update deprecated Beaker methods #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
from
7190022 to
e99bd35
Compare
mhashizume
changed the title
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
from
e99bd35 to
a41f964
Compare
The assert_no_match method in Beaker was long deprecated then eventually removed altogether in voxpupuli/beaker@6282311 This commit updates all instances of assert_no_match in Facter's Beaker tests with refute_match.
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
from
a41f964 to
824c0a5
Compare
tvpartytonight
approved these changes
Feb 5, 2024
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
2 times, most recently
from
6b9d078 to
9c16c33
Compare
Closed
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
from
9c16c33 to
8a08f51
Compare
Previously in Beaker, you could use standalone stdout and stderr methods to access output from remote machines. These methods were deprecated in 2013 with voxpupuli/beaker@28b2510 and dropped entirely in voxpupuli/beaker@73a31c7. This commit removes these methods from Facter tests in favor of calling stdout and stderr methods on Result objects.
mhashizume
force-pushed
the
PA-5022/main/beaker-deprecated
branch
from
8a08f51 to
e4e4f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates several deprecated Beaker methods that were removed entirely in Beaker 5. This is in preparation for moving Facter to using Beaker 5 for tests.