Add processors.extensions fact

[jcpunk]

This should add in an extra set of attributes for finding your microarch or CPU extensions.

Addresses #2663

I'll probably need help with the tests...

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[joshcooper]

Adding notes from some debugging about the order-dependent test failure, which is showing up on Windows.

This passes:

PS C:\work\facter> bundle exec rspec './spec/facter/resolvers/uname_spec.rb[1:6]' --order random:12882
Run options: include {:ids=>{"./spec/facter/resolvers/uname_spec.rb"=>["1:6"]}}

Randomized with seed 12882
.

Finished in 0.03427 seconds (files took 2.63 seconds to load)
1 example, 0 failures

But this doesn't:

PS C:\work\facter> bundle exec rspec './spec/facter/resolvers/processors_spec.rb[1:1:1:1,1:1:1:2,1:1:1:3,1:1:1:4,1:1:2:1,1:1:2:2,1:1:2:3,1:2:1,1:2:2,1:2:3,1:3:1]' './spec/facter/resolvers/uname_spec.rb[1:6]' --order random:12882
Run options: include {:ids=>{"./spec/facter/resolvers/processors_spec.rb"=>["1:1:1:1", "1:1:1:2", "1:1:1:3", "1:1:1:4", "1:1:2:1", "1:1:2:2", "1:1:2:3", "1:2:1", "1:2:2", "1:2:3", "1:3:1"], "./spec/facter/resolvers/uname_spec.rb"=>["1:6"]}}

Randomized with seed 12882
.E, [2024-04-09T17:29:24.293199 #4448] ERROR -- : Facter::Resolvers::Linux::Processors - Resolving fact models, but got undefined method `error' for Facter::Log:Class

        log.error("Resolving fact #{fact_name}, but got #{e} at #{e.backtrace[0]}")
           ^^^^^^
Did you mean?  errors? at C:/work/facter/lib/facter/resolvers/base_resolver.rb:31:in `rescue in resolve'
...

It seems there's a logger instance spy leaking from one test to another.

First, we're not consistent with how loggers are initialized, for example, this is evaluated as soon as the resolver is required:

facter/lib/facter/resolvers/processors.rb

Line 7 in dbfb450

@log = Facter::Log.new(self)

But this is done lazily:

facter/lib/facter/resolvers/base_resolver.rb

Lines 6 to 8 in dbfb450

	def self.log
	@log ||= Log.new(self)
	end

Also the resolver tests aren't consistent with using instance_spy's, for example, here we use the real Facter::Log class:

facter/spec/facter/resolvers/uname_spec.rb

Line 6 in 5194a37

let(:log_spy) { Facter::Log }

Here we use an instance_spy:

facter/spec/facter/resolvers/partitions_spec.rb

Line 8 in 5194a37

let(:logger) { instance_spy(Facter::Log) }

And here we don't specify a logger at all:

facter/spec/facter/resolvers/processors_spec.rb

Lines 3 to 6 in 5194a37

	describe Facter::Resolvers::Linux::Processors do
	after do
	Facter::Resolvers::Linux::Processors.invalidate_cache
	end

[jcpunk]

Rebased off HEAD

[joshcooper]

$ bundle exec facter processors.extensions
[
  "x86_64",
  "x86_64-v1",
  "x86_64-v2",
  "x86_64-v3",
  "x86_64-v4"
]

[joshcooper]

Thanks @jcpunk !