(FACT-3451) extend amazon linux os release fact #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0tw1r3
force-pushed
the
FACT-3451-extended-release
branch
2 times, most recently
from
0df9804 to
35726dc
Compare
mhashizume
reviewed
Dec 13, 2023
h0tw1r3
force-pushed
the
FACT-3451-extended-release
branch
2 times, most recently
from
c86244a to
f6192c2
Compare
mhashizume
reviewed
Dec 18, 2023
h0tw1r3
force-pushed
the
FACT-3451-extended-release
branch
from
f6192c2 to
abba895
Compare
|
Closing and reopening to rekick checks |
mhashizume
approved these changes
Dec 18, 2023
|
This changed the defaultfor 'os.name' => :amazon, 'os.release.major' => ["2", "2023"]I'll put up a PR to restore the old fact behavior for Amazon 1 and 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing a package version seems to be the only way to do this on Amazon Linux 2023.
Fixes #2647
Semi-related, there's no codename in AL 2023, should 'n/a' really be a default value?