Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-3448) Add Amazon to base fact utility #2643

Merged

Conversation

mhashizume
Copy link
Contributor

This commit adds Amazon as a condition to the os_processors_and_kernel_expected_facts method.

@mhashizume
Copy link
Contributor Author

I haven't not been able to test this yet as there isn't a passing puppet-agent build that includes Amazon Linux.

Marking this as a draft until there is a passing build I can test against.

This commit adds Amazon as a condition to the
os_processors_and_kernel_expected_facts method.
@mhashizume mhashizume force-pushed the FACT-3448/main/amazon-base-facts branch from 8934cfd to 5c4397f Compare November 21, 2023 18:54
@mhashizume mhashizume marked this pull request as ready for review November 21, 2023 19:51
@mhashizume mhashizume requested a review from a team as a code owner November 21, 2023 19:51
@cthorn42 cthorn42 merged commit 7b820bc into puppetlabs:main Nov 21, 2023
17 checks passed
@mhashizume mhashizume deleted the FACT-3448/main/amazon-base-facts branch November 21, 2023 23:45
@joshcooper joshcooper added the maintenance Maintenance chores are excluded from changelogs label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants