Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-2892) Fixes for primary interface on solaris 11 #2227

Merged
merged 1 commit into from
Dec 11, 2020
Merged

(FACT-2892) Fixes for primary interface on solaris 11 #2227

merged 1 commit into from
Dec 11, 2020

Conversation

sebastian-miclea
Copy link
Contributor

No description provided.

@sebastian-miclea sebastian-miclea requested review from a team December 11, 2020 08:13
@sebastian-miclea
Copy link
Contributor Author

Jenkins please test this on solaris11-64a

@sebastian-miclea sebastian-miclea changed the title (FACT-2892) Fixes for primary interface on solaris 10 (FACT-2892) Fixes for primary interface on solaris 11 Dec 11, 2020
@sebastian-miclea sebastian-miclea added the bug Something isn't working label Dec 11, 2020
@Filipovici-Andrei
Copy link
Contributor

You also need to replace the dhcp assignment with:
dhcp = Facter::Util::Resolvers::Networking::Dhcp.get(lifreq.name, @log)
@interfaces[lifreq.name][:dhcp] = dhcp if dhcp && !dhcp.empty?

@sebastian-miclea
Copy link
Contributor Author

Jenkins please test this on solaris11-64a

@Filipovici-Andrei Filipovici-Andrei merged commit 8dffc51 into puppetlabs:main Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Filipovici-Andrei Filipovici-Andrei Filipovici-Andrei approved these changes

@oanatmaria oanatmaria oanatmaria approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastian-miclea @Filipovici-Andrei @oanatmaria