Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-2811) part2. Fixed all unit tests which failed with rspec --order rand #2143

Merged
merged 1 commit into from
Oct 20, 2020
Merged

(FACT-2811) part2. Fixed all unit tests which failed with rspec --order rand #2143

merged 1 commit into from
Oct 20, 2020

Conversation

Filipovici-Andrei
Copy link
Contributor

@Filipovici-Andrei Filipovici-Andrei commented Oct 15, 2020 •
edited
Loading

This PR fixes the remaining unit tests that fail when running them with rspec --order random

  • Removed all class instance attributes from the resolvers which were caching their values. This meant that the invalidate_cache method for resolvers was not working properly.
  • Instantiated the FactManager singleton for every unit test that needed it.
  • Added default values for all OptionStore attributes and included them in the reset method.
  • check.sh now uses rspec --order random
  • Refactored some unit tests for linux partitions resolver.

@Filipovici-Andrei Filipovici-Andrei added do not merge maintenance Maintenance chores are excluded from changelogs labels Oct 15, 2020
@Filipovici-Andrei Filipovici-Andrei requested review from a team October 15, 2020 11:41
@Filipovici-Andrei Filipovici-Andrei changed the title (FACT-2811) part2. Finished solving failing unit tests (FACT-2811) part2. Fixed all failing unit tests with rspec --order rand Oct 15, 2020
@Filipovici-Andrei
Copy link
Contributor Author

jenkins please test this on all

@Filipovici-Andrei Filipovici-Andrei changed the title (FACT-2811) part2. Fixed all failing unit tests with rspec --order rand (FACT-2811) part2. Fixed all unit tests which failed with rspec --order rand Oct 15, 2020
@Filipovici-Andrei
Copy link
Contributor Author

jenkins please test this on all

@puppetcla
Copy link

CLA signed by all contributors.

@sebastian-miclea sebastian-miclea merged commit 6f1c5a1 into puppetlabs:main Oct 20, 2020
@Filipovici-Andrei Filipovici-Andrei deleted the FACT-28112 branch October 20, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-miclea sebastian-miclea sebastian-miclea approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Filipovici-Andrei @puppetcla @sebastian-miclea