(FACT-2826) Added Facter.flush #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-miclea
added
the
maintenance
|
CLA signed by all contributors. |
sebastian-miclea
force-pushed
the
FACT-2826
branch
from
82a9be4 to
ea66c87
Compare
|
Jenkins please test this on all |
sebastian-miclea
force-pushed
the
FACT-2826
branch
2 times, most recently
from
debfc2c to
5d225e6
Compare
Filipovici-Andrei
suggested changes
Oct 19, 2020
acceptance/tests/facter_flush.rb
Outdated
|
|
||
| Facter.flush | ||
|
|
||
| puts "Fact1: \#\{Facter.value(:fact)\}" |
There was a problem hiding this comment.
you are asking for a fact that doesn't exist
There was a problem hiding this comment.
Yes, missed that. Thanks
| @@ -403,6 +403,20 @@ def mock_collection(method, os_name = nil, error = nil) | |||
| end | |||
| end | |||
|
|
|||
| describe '#flush' do | |||
| it 'sends call to LegacyFacter' do | |||
| allow(LegacyFacter).to receive(:flush) | |||
There was a problem hiding this comment.
unit test should be separated according to the AAA pattern (Arrange, Act, Assert).
There was a problem hiding this comment.
Updated. Thanks!
sebastian-miclea
force-pushed
the
FACT-2826
branch
from
5d225e6 to
395a0ad
Compare
Filipovici-Andrei
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facter flush sets the resolved value to nil without restarting the resolution. Besides that flushing can be hooked using on_flush in custom facts.