New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Revert facter -p until we upgrade modules that use facter -p. #2131

Merged

sebastian-miclea merged 1 commit into puppetlabs:main from BogdanIrimie:maint-revert-facter-p

Oct 12, 2020

Contributor

BogdanIrimie commented Oct 9, 2020

There are still modules that depend on facter -p e.g https://github.com/puppetlabs/puppetlabs-facts/blob/master/tasks/ruby.rb . We should change these modules to use puppet facts show and only after we upgrade them, remove -p from facter.


          (maint) Revert facter -p until we upgrade modules that use facter -p.

e331e34

BogdanIrimie requested review from a team

October 9, 2020 13:32

BogdanIrimie added the maintenance label

puppetcla commented Oct 9, 2020

CLA signed by all contributors.

sebastian-miclea approved these changes

View reviewed changes

sebastian-miclea merged commit 029d4cf into puppetlabs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels