(FACT-2809) Fixed output differences on solaris #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins please test this on all |
|
CLA signed by all contributors. |
Filipovici-Andrei
suggested changes
Oct 6, 2020
| mounts << Hash[FilesystemHelper::MOUNT_KEYS.zip(FilesystemHelper::MOUNT_KEYS | ||
| .map { |v| binding.local_variable_get(v) })] | ||
| end | ||
| @fact_list[:mountpoints] = mounts |
There was a problem hiding this comment.
We should return @fact_list[fact_name]
| device | ||
| end | ||
|
|
||
| def read_mounts # rubocop:disable Metrics/AbcSize |
There was a problem hiding this comment.
We should split this method to avoid disabling rubocop
sebastian-miclea
force-pushed
the
FACT-2809
branch
2 times, most recently
from
00f25df to
1ea61d5
Compare
Filipovici-Andrei
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running the tests that compares output between Facter3 and Facter4 we've noticed some differences.
The differences were in: mountpoints (some were skipped), zones (count) and mtu.