(FACT-2798) Set color to true, fix Facter.log_exception #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filipovici-Andrei
force-pushed
the
FACT-2798
branch
from
d9cccf6 to
d0d0439
Compare
|
CLA signed by all contributors. |
Filipovici-Andrei
force-pushed
the
FACT-2798
branch
3 times, most recently
from
caa3c9b to
dabfa01
Compare
Facter.log_exception is fixed colorize is enabled for windows
Filipovici-Andrei
force-pushed
the
FACT-2798
branch
from
dabfa01 to
b9f5a28
Compare
|
jenkins please test this on all |
|
jenkins please test this on all |
sebastian-miclea
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Now by default all messages are colored.
Colored messages on Windows are enabled.
Fixed:
Setting color option to true on Centos 6, breaks facter.
Facter.log_exception now accepts any kind of message objects,
exceptions with or without backtrace.