Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Fix facter install on windows. #2092

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

Filipovici-Andrei
Copy link
Contributor

Added missing quotes for path parameters when calling install.rb
The script will now exit if any command fails.
Set defaults for SHA, FACTER_ROOT and RELEASE_STREAM,
for manual testing purposes.

@Filipovici-Andrei Filipovici-Andrei requested review from a team September 17, 2020 13:09
@Filipovici-Andrei Filipovici-Andrei changed the title (main) Fix facter install on windows. (maint) Fix facter install on windows. Sep 17, 2020
@Filipovici-Andrei Filipovici-Andrei added the maintenance Maintenance chores are excluded from changelogs label Sep 17, 2020
@Filipovici-Andrei Filipovici-Andrei force-pushed the fix_github branch 2 times, most recently from d6e23d0 to 4c2cf68 Compare September 17, 2020 13:58
@puppetcla
Copy link

CLA signed by all contributors.

Exit if any command fails.
Set defaults for SHA, FACTER_ROOT and RELEASE_STREAM
@sebastian-miclea sebastian-miclea merged commit a8c5dc3 into puppetlabs:main Sep 18, 2020
@Filipovici-Andrei Filipovici-Andrei deleted the fix_github branch September 18, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants