(FACT-2793) Time limit for Facter::Core::Execute #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
oanatmaria
force-pushed
the
FACT-2793
branch
2 times, most recently
from
672ef77 to
4598f52
Compare
oanatmaria
force-pushed
the
FACT-2793
branch
6 times, most recently
from
c0d64ba to
8a48917
Compare
|
Jenkins please test this on windows2012r2-64a,windowsfips2012r2-64a |
oanatmaria
force-pushed
the
FACT-2793
branch
2 times, most recently
from
f76f816 to
282946c
Compare
|
jenkins please test this on windows2019-64a |
oanatmaria
force-pushed
the
FACT-2793
branch
10 times, most recently
from
6ff24e6 to
0dd3865
Compare
|
Jenkins please test this on all |
gimmyxd
reviewed
Sep 18, 2020
BogdanIrimie
approved these changes
Sep 21, 2020
Filipovici-Andrei
suggested changes
Sep 21, 2020
oanatmaria
force-pushed
the
FACT-2793
branch
from
0dd3865 to
7e8b689
Compare
|
Jenkins please test this on all |
oanatmaria
force-pushed
the
FACT-2793
branch
from
7e8b689 to
c5afaa8
Compare
|
Jenkins please test this on all |
Filipovici-Andrei
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem:
Open3.capture3sometimes can hang for indefinite time.Description of the fix:
Facter::Core::Executecan be configured with a time limit after which the pid for the process that executes the command is killed. If no time limit is specified the command will time out after 1.5 seconds.