(FACT-2561) Fix blocking mechanism #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanatmaria
changed the title
|
Jenkins please test this on all |
|
CLA signed by all contributors. |
|
Jenkins please test this on all |
sebastian-miclea
approved these changes
Aug 26, 2020
BogdanIrimie
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem Facts with aliases can be blocked only if all aliases are blocked
Description of the solution Blocking one core fact should block all legacy facts (aliases) that are equivalent to that fact. When an alias (legacy fact) is blocked, only the legacy fact is blocked without blocking the equivalent core fact.