Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-2722) Add disks fact for Solaris #2027

Merged
merged 2 commits into from
Aug 18, 2020
Merged

(FACT-2722) Add disks fact for Solaris #2027

merged 2 commits into from
Aug 18, 2020

Conversation

Filipovici-Andrei
Copy link
Contributor

No description provided.

@Filipovici-Andrei Filipovici-Andrei added the enhancement New feature or enhancement label Aug 12, 2020
@Filipovici-Andrei Filipovici-Andrei requested review from a team August 12, 2020 16:19
@Filipovici-Andrei Filipovici-Andrei force-pushed the FACT-2722 branch 2 times, most recently from dfcdeef to 974c610 Compare August 12, 2020 16:36
@Filipovici-Andrei
Copy link
Contributor Author

jenkins please test this on all

igalic
igalic suggested changes Aug 12, 2020
View reviewed changes
Copy link

@igalic igalic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the restructuring of the code a separate commit or even pull request, cuz it's hard to follow what's going on given the commit message

and there's not much more explanation in FACT-2722 either

@puppetcla
Copy link

CLA signed by all contributors.

@Filipovici-Andrei
Copy link
Contributor Author

Sure @igalic. That's a reasonable request.

BogdanIrimie
BogdanIrimie reviewed Aug 14, 2020
View reviewed changes
lib/facter/resolvers/load_averages.rb Outdated Show resolved Hide resolved
lib/facter/resolvers/solaris/disks.rb Outdated Show resolved Hide resolved
@BogdanIrimie BogdanIrimie merged commit cb3e909 into puppetlabs:4.x Aug 18, 2020
@Filipovici-Andrei Filipovici-Andrei deleted the FACT-2722 branch August 19, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic requested changes

@BogdanIrimie BogdanIrimie BogdanIrimie approved these changes

Assignees
No one assigned
Labels
enhancement New feature or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Filipovici-Andrei @puppetcla @igalic @BogdanIrimie