Add FreeBSD memory facts #2020
Merged
Add FreeBSD memory facts #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
smortex
force-pushed
the
add-freebsd-memory-facts
branch
from
dded107 to
23b2c8e
Compare
smortex
force-pushed
the
add-freebsd-memory-facts
branch
from
23b2c8e to
733e5ca
Compare
|
CLA signed by all contributors. |
|
@IrimieBogdan I added a commit that fix the issues you listed, thank you for catching them, I mostly copied the Solaris facts which mix old and new style specs. Should these be updated too (I mean in this PR, or do we keep the focus on FreeBSD memory facts here)? |
|
let's clean up solaris tests in a next round |
oanatmaria
reviewed
Aug 11, 2020
smortex
force-pushed
the
add-freebsd-memory-facts
branch
from
eef6301 to
40e14ab
Compare
oanatmaria
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect system and swap memory information on FreeBSD
🎁 @igalic
The memory facts where not provided by Facter 4. With this PR, Facter returns the same facts as Facter 3 does.