-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(FACT-2732) OracleLinux 7 and Scientific Linux 7 OS facts incorrect in Facter 4.0.30 #2014
Conversation
jenkins please test this on redhat7-64a,ubuntu1604-64a,aix61-POWERfa,amazon6-64a,amazon7-64a,debian9-64a,debian9-32a,debian10-64a,fedora30-64a,fedora31-64a,fedora32-64a,osx1014-64a,osx1015-64a,centos6-64a,centos6-32a,centos8-64a,redhat7-AARCH64a,redhat8-64a,redhatfips7-64a,sles12-64a,sles12-POWERa,sles15-64a,solaris11-64a,solaris114-64a,ubuntu1604-32a,ubuntu1604-POWERa,ubuntu1804-64a,ubuntu2004-64a,windows10ent-64a,windows10ent-32a,windows2012r2-64a,windows2016-64a,windows2019-64a,windowsfips2012r2-64a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A unit test for this particular case in the os_release_resolver_spec?
Tested on Oracle Linux 7:
After this fix was applied:
|
This also fixes the issue on Scientific linux 7:
After the fix:
|
@Filipovici-Andrei added a unit test for Oracle Linux name detection from |
Added Oracle and Scientific Linux to
os_hierarchy.json
under Red Hat Enterprise Linux. Before the addition, they were considered default linux distributions.