Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-2678) Facter sometimes pollutes the calling processes environment (race condition) #1932

Merged
merged 1 commit into from
Jun 24, 2020
Merged

(FACT-2678) Facter sometimes pollutes the calling processes environment (race condition) #1932

merged 1 commit into from
Jun 24, 2020

Conversation

BogdanIrimie
Copy link
Contributor

@BogdanIrimie BogdanIrimie commented Jun 24, 2020 •
edited
Loading

Only set environment variables on Open3 call to avoid race condition for core facts.

@BogdanIrimie BogdanIrimie added the bug Something isn't working label Jun 24, 2020
@BogdanIrimie BogdanIrimie requested review from a team June 24, 2020 08:11
@oanatmaria oanatmaria merged commit 493981f into 4.x Jun 24, 2020
@mihaibuzgau mihaibuzgau deleted the FACT-2678 branch June 29, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Filipovici-Andrei Filipovici-Andrei Filipovici-Andrei approved these changes

@sebastian-miclea sebastian-miclea sebastian-miclea approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BogdanIrimie @sebastian-miclea @Filipovici-Andrei @oanatmaria