Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-2668) Networking fact on linux should have logic for selecting IPs #1928

Merged
merged 23 commits into from
Jun 23, 2020

Conversation

BogdanIrimie
Copy link
Contributor

@BogdanIrimie BogdanIrimie commented Jun 19, 2020

127.0.0.1 should be the last IP that should be configured as default.

Andrei Filipovici and others added 20 commits June 9, 2020 09:08
…solver utils and added it to osx interfaces fact
…solver utils and added it to osx interfaces fact
# Conflicts:
#	lib/resolvers/networking_linux_resolver.rb
@puppetcla
Copy link

CLA signed by all contributors.

@BogdanIrimie BogdanIrimie added the bug Something isn't working label Jun 22, 2020
@BogdanIrimie BogdanIrimie marked this pull request as ready for review June 23, 2020 07:24
@BogdanIrimie BogdanIrimie requested review from a team June 23, 2020 07:24
BogdanIrimie added 2 commits June 23, 2020 10:46
# Conflicts:
#	lib/facts/macosx/interfaces.rb
#	lib/resolvers/macosx/networking.rb
#	spec/facter/facts/macosx/networking/interfaces_spec.rb
#	spec/facter/facts/macosx/networking/network_spec.rb
#	spec/facter/resolvers/utils/networking_spec.rb
@Filipovici-Andrei Filipovici-Andrei merged commit 93b7e1f into 4.x Jun 23, 2020
@mihaibuzgau mihaibuzgau deleted the FACT-2668 branch June 29, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants