Skip to content

Commit

Permalink
(FACT-3432) Pin FFI to 1.15.5
Browse files Browse the repository at this point in the history
FFI version 1.16.0 was released and introduced breaking changes to code
that extends the FFI library. This causes Facter to fail on Windows.

This commit pins the FFI development dependency to 1.15.5 (the last
version prior to 1.16.0) until we can resolve these issues.
  • Loading branch information
mhashizume committed Sep 26, 2023
1 parent 163e1bb commit 83f15dc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ gem 'packaging', require: false
local_gemfile = File.expand_path('Gemfile.local', __dir__)
eval_gemfile(local_gemfile) if File.exist?(local_gemfile)

# ffi >= 1.16.0 introduces breaking changes, so we pin to the version prior
# for now
group(:integration, optional: true) do
gem 'ffi', '~> 1.15', require: false
gem 'ffi', '1.15.5', require: false
end

group(:documentation) do
Expand Down
2 changes: 1 addition & 1 deletion facter.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Gem::Specification.new do |spec|
# or indirectly contain native extensions. The intent behind excluding these
# gems from runtime dependencies is to allow users to be able to install
# Facter without a compiler.
spec.add_development_dependency 'ffi'
spec.add_development_dependency 'ffi', '1.15.5'
spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'rubocop', '~> 0.81.0'
Expand Down

0 comments on commit 83f15dc

Please sign in to comment.