(maint) remove rescue Exception

Since ths methods is just doing a YAML.safe_load there is no point in rescueing `Exception`.
puppetlabs · Jul 16, 2020 · 5fc2f9c · 5fc2f9c
1 parent bdd588a
commit 5fc2f9c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -13,10 +13,6 @@ require:
 Layout/LineLength:
   Max: 120
 
-Lint/RescueException:
-  Exclude:
-    - 'lib/facter/custom_facts/util/parser.rb'
-
 Lint/RaiseException:
   Enabled: true
 

diff --git a/lib/facter/custom_facts/util/parser.rb b/lib/facter/custom_facts/util/parser.rb
@@ -69,7 +69,7 @@ def parse_executable_output(output)
           res = nil
           begin
             res = YAML.safe_load(output, [Symbol, Time])
-          rescue Exception => e
+          rescue StandardError => e
             Facter.debug("Could not parse executable fact output as YAML or JSON (#{e.message})")
           end
           res = KeyValuePairOutputFormat.parse output unless res.is_a?(Hash)