This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
(FACT-2638) Use puppet AIO VERSION file to specify AIO version #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanatmaria
reviewed
Jun 11, 2020
I have a small concern with this approach as we will ship facter as a gem component in Puppet(that means it can be managed using puppet gem command). This means that it will be upgradable using |
…atforms that are not yet implemented.
Change implementation to read agent aio version from puppet installation path. |
sebastian-miclea
previously approved these changes
Jun 15, 2020
gimmyxd
reviewed
Jun 15, 2020
gimmyxd
reviewed
Jun 16, 2020
…y one detected in registry. Added tests for this case.
@IrimieBogdan there is a small difference comparing facter 4 to facter 3
|
gimmyxd
previously approved these changes
Jun 16, 2020
BogdanIrimie
changed the title
(FACT-2638) Use facter-ng.gemspec to specify AIO version
(FACT-2638) Use puppet AIO VERSION file to specify AIO version
Jun 16, 2020
gimmyxd
approved these changes
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet
aio_agent_version
will be read from the location where puppet AIO is installed. By doing this, all facter instances installed on the system will be able to detect agent AIO version.