Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

(FACT-2638) Use puppet AIO VERSION file to specify AIO version #549

Merged
merged 26 commits into from
Jun 16, 2020

Conversation

BogdanIrimie
Copy link
Contributor

@BogdanIrimie BogdanIrimie commented Jun 11, 2020

Puppet aio_agent_version will be read from the location where puppet AIO is installed. By doing this, all facter instances installed on the system will be able to detect agent AIO version.

@BogdanIrimie BogdanIrimie requested review from a team June 11, 2020 13:33
@gimmyxd
Copy link
Contributor

gimmyxd commented Jun 11, 2020

I have a small concern with this approach as we will ship facter as a gem component in Puppet(that means it can be managed using puppet gem command). This means that it will be upgradable using /opt/puppetlabas/puppet/bin gem update facter which can install a new version of facter that will not have the agent version file.

@BogdanIrimie BogdanIrimie requested review from oanatmaria, gimmyxd and a team June 15, 2020 13:35
@BogdanIrimie BogdanIrimie requested a review from a team June 15, 2020 13:35
@BogdanIrimie
Copy link
Contributor Author

Change implementation to read agent aio version from puppet installation path.

lib/resolvers/windows/aio_agent_version.rb Outdated Show resolved Hide resolved
lib/resolvers/windows/aio_agent_version.rb Show resolved Hide resolved
lib/resolvers/windows/aio_agent_version.rb Outdated Show resolved Hide resolved
…y one detected in registry. Added tests for this case.
@gimmyxd
Copy link
Contributor

gimmyxd commented Jun 16, 2020

@IrimieBogdan there is a small difference comparing facter 4 to facter 3

❯ /opt/puppetlabs/bin/facter --version
3.14.12 (commit 7b4c3bd15d90faf9978e7ef32a34e8cc91a1ca73)
❯ /opt/puppetlabs/bin/facter aio_agent_version
6.16.0.75


❯ git log -n 1
commit d775e63db4025732e60151735825762960f2ff0f (HEAD -> FACT-2638, origin/FACT-2638)
❯ bundle exec facter aio_agent_version
6.16.0.75.g625aab0b


❯ /opt/puppetlabs/bin/puppet --version
6.17.0

gimmyxd
gimmyxd previously approved these changes Jun 16, 2020
@BogdanIrimie BogdanIrimie changed the title (FACT-2638) Use facter-ng.gemspec to specify AIO version (FACT-2638) Use puppet AIO VERSION file to specify AIO version Jun 16, 2020
@BogdanIrimie BogdanIrimie merged commit cc66565 into master Jun 16, 2020
@BogdanIrimie BogdanIrimie deleted the FACT-2638 branch June 16, 2020 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants