This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2515) Define custom fact groups in facter.conf #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florindragos
force-pushed
the
FACT-2515
branch
3 times, most recently
from
2d635f5 to
fee408b
Compare
BogdanIrimie
reviewed
May 6, 2020
| @@ -10,6 +10,7 @@ | |||
| allow(Facter::ConfigReader).to receive(:init).and_return(config_reader) | |||
| allow(config_reader).to receive(:block_list).and_return([]) | |||
| allow(config_reader).to receive(:ttls).and_return([]) | |||
| allow(config_reader).to receive(:fact_groups).and_return({}) | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Add tests for merging of default groups with user defined groups.
florindragos
force-pushed
the
FACT-2515
branch
2 times, most recently
from
14de708 to
6215eed
Compare
BogdanIrimie
approved these changes
May 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.