This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2565) Debian development versions causes fatal error when resolving os.release #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2020 13:18
refactored unit tests
…the failure is logged
oanatmaria
reviewed
Apr 22, 2020
BogdanIrimie
previously approved these changes
Apr 24, 2020
BogdanIrimie
approved these changes
Apr 24, 2020
gimmyxd
reviewed
Apr 24, 2020
Comment on lines
+28
to
+34
| begin | ||
| fact = CoreFact.new(searched_fact) | ||
| fact.create | ||
| rescue StandardError => e | ||
| @@log.error(e.backtrace.join("\n")) | ||
| nil | ||
| end |
There was a problem hiding this comment.
This will catch all the errors, even dev errors and unhandled cases even from resolvers and will just output a backtrace. I don't think this is the way to go for this situation.
If i call a method on nil in the resolver, this part will catch it for example and return nil, passing nil around and generating more errors.
Filipovici-Andrei
added a commit
that referenced
this pull request
Apr 28, 2020
…ving os.release (#466) * (FACT-2565) fixed fact for when release does not have minor version refactored unit tests * (FACT-2565) when fact throws exception, it's value is not stored and the failure is logged * (FACT-2565) simplified condition for release minor * (FACT-2565) refactore release hash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.