This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2564) Add support for zpool_featureflags and fix zpool_version #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hi, could you please open a Jira ticket for this changes? |
oanatmaria
reviewed
Apr 15, 2020
smortex
force-pushed
the
zpool_featureflags_and_version
branch
4 times, most recently
from
987e595 to
70269f5
Compare
|
I just opened https://tickets.puppetlabs.com/browse/FACT-2564, added tests as requested and rebased the whole on top of master with a reference to the Jira issue in the squashed commit message. Thanks! |
smortex
changed the title
smortex
force-pushed
the
zpool_featureflags_and_version
branch
from
9e1dcce to
d763915
Compare
This allows facter-ng to return the same facts as facter 3.x. This changes took place in facter 3.8.0: puppetlabs/facter#1597
smortex
force-pushed
the
zpool_featureflags_and_version
branch
from
d763915 to
582e1dc
Compare
oanatmaria
approved these changes
Apr 24, 2020
Filipovici-Andrei
pushed a commit
that referenced
this pull request
Apr 28, 2020
…443) * (FACT-2564) Add support for zpool_featureflags and fix zpool_version This allows facter-ng to return the same facts as facter 3.x. This changes took place in facter 3.8.0: puppetlabs/facter#1597 * (FACT-2564) Move zpool feature flags in a let statement Co-authored-by: Bogdan Irimie <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows facter-ng to return the same facts as facter 3.x.
This changes took place in facter 3.8.0 and was discussed here:
puppetlabs/facter#1597