Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

(FACT-2528) Fix for tests/facts/ssh_key.rb #442

Merged
merged 1 commit into from
Apr 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/framework/parsers/query_parser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def get_facts_matching_tokens(query_tokens, query_token_range, loaded_fact_hash)
end

def found_fact?(fact_name, query_fact)
fact_with_wildcard = fact_name.include?('.*')
fact_with_wildcard = fact_name.include?('.*') && !query_fact.include?('.')

return false if fact_with_wildcard && !query_fact.match("^#{fact_name}$")

Expand Down
16 changes: 16 additions & 0 deletions spec/facter/query_parser_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,22 @@
contain_exactly(an_instance_of(Facter::SearchedFact).and(having_attributes(fact_class: networking_class)))
end

it 'creates a searched fact correctly without name collision' do
query_list = ['ssh.rsa.key']

ssh_class = 'Facter::El::Ssh'
ssh_key_class = 'Facter::El::Sshalgorithmkey'

loaded_fact_ssh_key = instance_spy(Facter::LoadedFact, name: 'ssh.*key', klass: ssh_key_class, type: :legacy)
loaded_fact_ssh = instance_spy(Facter::LoadedFact, name: 'ssh', klass: ssh_class, type: :core)
loaded_facts = [loaded_fact_ssh_key, loaded_fact_ssh]

matched_facts = Facter::QueryParser.parse(query_list, loaded_facts)

expect(matched_facts).to be_an_instance_of(Array).and \
contain_exactly(an_instance_of(Facter::SearchedFact).and(having_attributes(fact_class: ssh_class)))
end

it 'creates one custom searched fact' do
query_list = ['custom_fact']
os_name_class = 'Facter::Ubuntu::OsName'
Expand Down