(maint) Avoid mutating frozen string #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid risk of RunTime errors related to mutating frozen strings by not modifying puppet_collection in place.
ekohl
reviewed
Jan 28, 2019
| @@ -362,7 +362,8 @@ def install_puppet_agent_on(hosts, opts = {}) | |||
| opts[:puppet_agent_version] ||= opts[:version] #backwards compatability with old parameter name | |||
| opts[:puppet_collection] ||= puppet_collection_for(:puppet_agent, opts[:puppet_agent_version]) || 'pc1' | |||
There was a problem hiding this comment.
Should puppet_collection_for return a downcased collection instead?
There was a problem hiding this comment.
fair question, but since there is some time pressure due to caused failures from the earlier change & what you're suggesting is functionally equivalent, I'm going to move forward with merging & releasing this change as-is.
Please propose a new PR with your suggested change if you'd like to pursue this further in a later release.
|
Hi people. I tested this fix and can confirm that it works for the Vox Pupuli org. I also suggest adding |
This was referenced Jan 28, 2019
kevpl
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid risk of RunTime errors related to mutating frozen strings by not modifying puppet_collection in place.