(MAINT) remove wait_for_host_in_dashboard call

[kevpl]

@jonathannewman submitted the original change request in voxpupuli/beaker#1339.

@puppetlabs/integration do you think there are any versions we're still testing that would be affected by this?

[jonathannewman]

@kevpl this is only meaningful for PE 3.8 and earlier. It is completely safe to remove.

[puppetlabs-jenkins]

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/174/

[tvpartytonight]

nit: there's a lot of references to wait_for_host_in_dashboard in the spec tests; maybe we should get ride of them? Looks like they are all allow methods instead of expect, so they didn't cause any breakage with this change.

[ericwilliamson]

👍 from me.

@nicklewis May have some "fresh" knowledge in this area since he was just in this area refactoring things for orchestrator. Do you forsee any issues removing it?

[nicklewis]

👍 This should be safe to remove. It shouldn't even be necessary in 3.7/3.8.

[puppetlabs-jenkins]

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/175/

[tvpartytonight]

Acceptance test failure is unrelated to change; the previous one passed, and this new test run only included new spec test changes, so as long as those pass, I'm a 👍 .