Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-19086 Change extend gpg key to ignore gpg key warnings #47

Conversation

cthorn42
Copy link
Collaborator

@cthorn42 cthorn42 commented Jan 5, 2017

The extended GPG-key for PE 2015.2 -> 2016.1.2 has expired.
Rather then continue to update it every few months, lets just
enable the older versions of PE that are installed on debian
systems to ignore gpg-key warnings.
We will still have testing coverage of the gpg-key on debian
systems via fresh installs of PE and testing upgrades from
PE 2016.2.0 and newer.

@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/145/

@cthorn42 cthorn42 force-pushed the maint/master/PE-19086_ignore_gpg_key_pre_2016.2 branch from 038983a to 78bcfff Compare January 5, 2017 23:50
@cthorn42
Copy link
Collaborator Author

cthorn42 commented Jan 5, 2017

Looks like I was wrong about the lower end, PE 3.8.5, and PE 3.8.6 both now come with an expired key. Updated the method to make sure if it is those versions to also add in the ignore gpg-key warning, also updated specs to reflect the new behavior.

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/146/

@cthorn42
Copy link
Collaborator Author

cthorn42 commented Jan 6, 2017

Bah humbug. Looks like PE 2016.2.1 also has an expired gpg-key. I need to do more research to really nail that down.

The extended GPG-key for PE 2015.2 -> 2016.1.2 has expired.
Rather then continue to update it every few months, lets just
enable the older versions of PE that are installed on debian
systems to ignore gpg-key warnings.
We will still have testing coverage of the gpg-key on debian
systems via fresh installs of PE and testing upgrades from
PE 2016.2.0 and newer.
@cthorn42 cthorn42 force-pushed the maint/master/PE-19086_ignore_gpg_key_pre_2016.2 branch from 78bcfff to bd3ef2f Compare January 6, 2017 16:30
@cthorn42
Copy link
Collaborator Author

cthorn42 commented Jan 6, 2017

Okay updated everything to reflect now every PE version less then 2016.4.0 needs this ignore method if it is deb/ubuntu.
2016.4.0 and up has a gpg key that expires in 2021, we should be good until then.

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/147/

@tvpartytonight
Copy link
Contributor

👍

1 similar comment
@kevpl
Copy link
Contributor

kevpl commented Jan 6, 2017

👍

@tvpartytonight tvpartytonight merged commit 45d907e into puppetlabs:master Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants