Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(QA-2620) update install_pe_client_tools_on to use package repo #26

Conversation

zreichert
Copy link
Contributor

No description provided.

@zreichert zreichert changed the title (QA-2620) update install_pe_client_tools_on to use package repo (WIP) update install_pe_client_tools_on to use package repo Sep 14, 2016
@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

when /win/
package_name = nil
release_path = "#{opts[:dev_builds_url]}/#{product}/#{ opts[:pe_client_tools_sha] }/artifacts/#{variant}"
package_name << "_#{opts[:pe_client_tools_version]}-1#{host['platform'].codename}_#{arch}.deb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we would install a deb package on Windows

when /windows/
when /win/
package_name = nil
release_path = "#{opts[:dev_builds_url]}/#{product}/#{ opts[:pe_client_tools_sha] }/artifacts/#{variant}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variant is not in scope here.

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/64/

@zreichert zreichert force-pushed the maint/master/QA-2620_fix_installation_noop_for_nix branch from 9ee3bc3 to b9e7285 Compare September 14, 2016 23:45
@johnduarte
Copy link
Contributor

Manually validated on Windows2012r2

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/65/

@zreichert zreichert force-pushed the maint/master/QA-2620_fix_installation_noop_for_nix branch from b9e7285 to 665da12 Compare September 15, 2016 16:13
@zreichert
Copy link
Contributor Author

@johnduarte Updated

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/66/

@johnduarte
Copy link
Contributor

Manually validated on Windows2012r2

@johnduarte
Copy link
Contributor

Manually validated on OSX 10.11

@zreichert zreichert changed the title (WIP) update install_pe_client_tools_on to use package repo (QA-2620) update install_pe_client_tools_on to use package repo Sep 15, 2016
@johnduarte
Copy link
Contributor

👍

@zreichert
Copy link
Contributor Author

@nicklewis can you take a look?

@johnduarte
Copy link
Contributor

retest this please

@nicklewis
Copy link
Contributor

I haven't tested this out (so there could be typoes / wrong paths, etc), but it makes sense to me.

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/67/

@zreichert
Copy link
Contributor Author

@puppetlabs/beaker Can I get a review and merge on this? This is blocking CI for a feature intended for Davis.

@kevpl
Copy link
Contributor

kevpl commented Sep 16, 2016

looks like your last automation run was hitting an intermittent failure.

@puppetlabs-jenkins retest this please

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/73/

@kevpl
Copy link
Contributor

kevpl commented Sep 16, 2016

@puppetlabs-jenkins retest this please

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/74/

@kevpl
Copy link
Contributor

kevpl commented Sep 16, 2016

@puppetlabs-jenkins retest this please

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/76/

@tvpartytonight
Copy link
Contributor

@puppetlabs-jenkins retest this please

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/77/

@zreichert
Copy link
Contributor Author

@puppetlabs-jenkins retest this please

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/78/

@johnduarte
Copy link
Contributor

@puppetlabs-jenkins retest this please

This merry-go-round is getting old. How much longer are we going to do this dance?

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/79/

@tvpartytonight
Copy link
Contributor

@puppetlabs-jenkins retest this please

@tvpartytonight
Copy link
Contributor

@johnduarte @zreichert this job was temporarily broken as we neglected to update it to use ruby 2.2.5 when we introduced breaking changes into beaker for the 3.0 release. When we updated it to ruby 2.2.5, we ended up breaking it even more, so we had to spend some time debugging that situation and running the validation again. This latest iteration should be good, but, the only certainties in life are death and taxes, so I wouldn't hold your breath. Sorry for pipeline breakage! 🚧 👷

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/80/

@tvpartytonight
Copy link
Contributor

@puppetlabs-jenkins retest this please

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/81/

@tvpartytonight
Copy link
Contributor

WHHOOOO!

windowcrash

@tvpartytonight tvpartytonight merged commit e75cdb0 into puppetlabs:master Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants