-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(QA-2620) update install_pe_client_tools_on to use package repo #26
(QA-2620) update install_pe_client_tools_on to use package repo #26
Conversation
Can one of the admins verify this patch? |
when /win/ | ||
package_name = nil | ||
release_path = "#{opts[:dev_builds_url]}/#{product}/#{ opts[:pe_client_tools_sha] }/artifacts/#{variant}" | ||
package_name << "_#{opts[:pe_client_tools_version]}-1#{host['platform'].codename}_#{arch}.deb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we would install a deb
package on Windows
when /windows/ | ||
when /win/ | ||
package_name = nil | ||
release_path = "#{opts[:dev_builds_url]}/#{product}/#{ opts[:pe_client_tools_sha] }/artifacts/#{variant}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variant
is not in scope here.
Refer to this link for build results (access rights to CI server needed): |
9ee3bc3
to
b9e7285
Compare
Manually validated on Windows2012r2 |
Refer to this link for build results (access rights to CI server needed): |
b9e7285
to
665da12
Compare
@johnduarte Updated |
Refer to this link for build results (access rights to CI server needed): |
Manually validated on Windows2012r2 |
Manually validated on OSX 10.11 |
👍 |
@nicklewis can you take a look? |
retest this please |
I haven't tested this out (so there could be typoes / wrong paths, etc), but it makes sense to me. |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs/beaker Can I get a review and merge on this? This is blocking CI for a feature intended for Davis. |
looks like your last automation run was hitting an intermittent failure. @puppetlabs-jenkins retest this please |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please This merry-go-round is getting old. How much longer are we going to do this dance? |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please |
@johnduarte @zreichert this job was temporarily broken as we neglected to update it to use ruby 2.2.5 when we introduced breaking changes into beaker for the 3.0 release. When we updated it to ruby 2.2.5, we ended up breaking it even more, so we had to spend some time debugging that situation and running the validation again. This latest iteration should be good, but, the only certainties in life are death and taxes, so I wouldn't hold your breath. Sorry for pipeline breakage! 🚧 👷 |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please |
Refer to this link for build results (access rights to CI server needed): |
No description provided.