(PE-14934) Test if puppetdb is up when running puppet agent on pdb node #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit we were running into an issue where puppetdb would sometimes not be up and running after puppet agent restarted the service. This commit waits for the puppetdb service to be up after running puppet agent on the database node so that the next agent run doesn't fail.
|
Have you had a chance to do a test run with this? And what about the upgrade case? |
|
Can one of the admins verify this patch? |
|
Attempting to run this right now, just getting eyes on it early would be nice |
|
Looks like upgrade_pe_on eventually hands to do_install as well. |
|
Frankenbuilder running now with the changes in this PR patched into beaker on ubuntu-14.04-amd64. |
|
@puppetlabs-jenkins test this please |
|
👍 |
|
Frankenbuilder passed \o/ |
|
👍 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit we were running into an issue where puppetdb would
sometimes not be up and running after puppet agent restarted the
service. This commit waits for the puppetdb service to be up after
running puppet agent on the database node so that the next agent run
doesn't fail.