-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PE-16566) Add method to download life support gpg key #14
(PE-16566) Add method to download life support gpg key #14
Conversation
running now with
|
Refer to this link for build results (access rights to CI server needed): |
passed my local frankenbuild run:
|
Specs are failing due to gem issues:
|
@puppetlabs-jenkins retest this please |
@@ -444,6 +444,79 @@ def slice_installer_options(host) | |||
end | |||
end | |||
|
|||
describe 'add_extended_gpg_key_to_hosts' do | |||
let(:on_cmd) { 'curl http://apt.puppetlabs.com/pubkey.gpg | apt-key add -' } | |||
let(:host) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be called out that this is the debian host? debian_host
or something? The specs below are a little confusing to read when they just say host
, my mind immediately thinks "yes, but which host?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh yes. Good catch. Was a last minute refactor. Updating...
👍 Looks good to me. Still wish we weren't doing it... |
Refer to this link for build results (access rights to CI server needed): |
As of July 8th, 2016 the GPG key that was shipped with and used to sign repos inside of PE tarballs expired. A new life support key was created that extended the expiration date to Jan 2017. That key shipped with PE 3.8.5 and 2016.1.2. apt based platforms appear to be the only package manager failing due to an expired key, while rpm is fine. This commit adds a new helper method to additionally download and install the extended key for PE versions that have already been released and are needing to be tested.
17c434c
to
df1f14b
Compare
Specs passed and a previous regression run succeeded, so this is ready for merge. |
Refer to this link for build results (access rights to CI server needed): |
As of July 8th, 2016 the GPG key that was shipped with and used to sign
repos inside of PE tarballs expired. A new life support key was created
that extended the expiration date to Jan 2017. That key shipped with PE
3.8.5 and 2016.1.2.
apt based platforms appear to be the only package manager failing due to
an expired key, while rpm is fine.
This commit adds a new helper method to additionally download and
install the extended key for PE versions that have already been released
and are needing to be tested.