Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-16566) Add method to download life support gpg key #14

Conversation

ericwilliamson
Copy link
Member

As of July 8th, 2016 the GPG key that was shipped with and used to sign
repos inside of PE tarballs expired. A new life support key was created
that extended the expiration date to Jan 2017. That key shipped with PE
3.8.5 and 2016.1.2.

apt based platforms appear to be the only package manager failing due to
an expired key, while rpm is fine.

This commit adds a new helper method to additionally download and
install the extended key for PE versions that have already been released
and are needing to be tested.

@ericwilliamson
Copy link
Member Author

running now with

./frankenbuilder 3.8 --install --smoke --platform debian-7-amd64 --mono --agent debian-7-i386 --upgrade --upgrade-from 3.3.2

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/29/

@ericwilliamson
Copy link
Member Author

passed my local frankenbuild run:

 - Host Configuration Summary -


              - Test Case Summary for suite 'tests' -
       Total Suite Time: 259.51 seconds
      Average Test Time: 5.41 seconds
              Attempted: 48
                 Passed: 43
                 Failed: 0
                Errored: 0
                Skipped: 5
                Pending: 0
                  Total: 48

      - Specific Test Case Status -

Failed Tests Cases:
Errored Tests Cases:
Skipped Tests Cases:
      Test Case /s/pe_acceptance_tests/acceptance/tests/pe_checks/QA-506_windows_exit_codes_test.rb skip
      Test Case /s/pe_acceptance_tests/acceptance/tests/pe_checks/QA-563_windows_exit_mcollective.rb skip
      Test Case /s/pe_acceptance_tests/acceptance/tests/pe_checks/QA-760_win_dash_dot_file_test.rb skip
      Test Case /s/pe_acceptance_tests/acceptance/tests/pe_checks/pe-2905-verify_no_deprecated_I18n_log_messages.rb skip
      Test Case /s/pe_acceptance_tests/acceptance/tests/simplified_agent/puppet_conf.rb skip
Pending Tests Cases:

    No tests to run for suite 'post_suite'
    No tests to run for suite 'pre_cleanup'

    You can reproduce this run with:
    /s/pe_acceptance_tests/.vendor/ruby/2.1.0/bin/beaker --tests=/s/pe_acceptance_tests/acceptance/tests --pre-suite=/s/pe_acceptance_tests/setup/install.rb,/s/pe_acceptance_tests/setup/upgrade.rb --config=/s/frankenbuilder/frankenbuild/beaker.yml

    You can re-run commands against the already provisioned SUT(s) with:
    /s/pe_acceptance_tests/.vendor/ruby/2.1.0/bin/beaker --tests=/s/pe_acceptance_tests/acceptance/tests --pre-suite=/s/pe_acceptance_tests/setup/install.rb,/s/pe_acceptance_tests/setup/upgrade.rb --config=/s/frankenbuilder/frankenbuild/beaker.yml

    Important ENV variables that may have affected your run:
        GEM_HOME                /s/pe_acceptance_tests/.vendor/ruby/2.1.0
        GEM_PATH
        RUBYLIB         /root/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/bundler-1.12.3/lib:/root/.rbenv/rbenv.d/exec/gem-rehash
        PATH            /s/pe_acceptance_tests/.vendor/ruby/2.1.0/bin:/root/.rbenv/versions/2.1.6/bin:/root/.rbenv/libexec:/root/.rbenv/plugins/ruby-build/bin:/root/.rbenv/shims:/root/.rbenv/bin:/root/bin:/root/.bin:/usr/local/bin:/usr/local/sbin:/usr/local/mysql/bin:/usr/local/git/bin:/usr/sbin:/usr/bin:/opt/puppetlabs/bin
        home            /root
Beaker completed successfully, thanks.
# Frankenbuilder Settings
# ----------------------------------------
# HYPERVISOR           | vmpooler
# CONFIGURATION        | mono
# BUILD                | 3.8.5
# UPGRADE_FROM         | 3.3.2
# PLATFORM             | debian-7-amd64
# TEMPLATE             | debian-7-x86_64
# PRE_SUITE_TESTS[@]   | /s/pe_acceptance_tests/setup/install.rb,/s/pe_acceptance_tests/setup/upgrade.rb
# TESTS[@]             | /s/pe_acceptance_tests/acceptance/tests/
# AGENTS[@]            | debian-7-i386
# PRESERVE_HOSTS       | always
# ----------------------------------------
# Rerun with: ./frankenbuilder 3.8.5 --install --smoke --platform debian-7-amd64 --mono --agent debian-7-i386 --upgrade --upgrade-from 3.3.2

@ericwilliamson
Copy link
Member Author

Specs are failing due to gem issues:

Gem::InstallError: activesupport requires Ruby version >= 2.2.2.
An error occurred while installing activesupport (5.0.0), and Bundler cannot
continue.

@tvpartytonight
Copy link
Contributor

@puppetlabs-jenkins retest this please

@@ -444,6 +444,79 @@ def slice_installer_options(host)
end
end

describe 'add_extended_gpg_key_to_hosts' do
let(:on_cmd) { 'curl http://apt.puppetlabs.com/pubkey.gpg | apt-key add -' }
let(:host) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be called out that this is the debian host? debian_host or something? The specs below are a little confusing to read when they just say host, my mind immediately thinks "yes, but which host?"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh yes. Good catch. Was a last minute refactor. Updating...

@jpartlow
Copy link
Contributor

👍 Looks good to me. Still wish we weren't doing it...

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/30/

As of July 8th, 2016 the GPG key that was shipped with and used to sign
repos inside of PE tarballs expired. A new life support key was created
that extended the expiration date to Jan 2017. That key shipped with PE
3.8.5 and 2016.1.2.

apt based platforms appear to be the only package manager failing due to
an expired key, while rpm is fine.

This commit adds a new helper method to additionally download and
install the extended key for PE versions that have already been released
and are needing to be tested.
@ericwilliamson ericwilliamson force-pushed the task/master/PE-16566-download-gpg-key branch from 17c434c to df1f14b Compare July 11, 2016 23:48
@tvpartytonight
Copy link
Contributor

Specs passed and a previous regression run succeeded, so this is ready for merge.

@tvpartytonight tvpartytonight merged commit 99c5008 into puppetlabs:master Jul 12, 2016
@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/31/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants