(PE-15351) Use -y option for 2016.2.1+ installs #12
Conversation
Prior to this commit there was not an option for signalling a non-interactive install to the installer. This commit adds the new `-f` option added in https://github.com/puppetlabs/pe-installer-shim/pull/31 to the command line options for installation/upgrade. Additionally, this commit will remove the `-c` parameter being passed on upgrades from a 2016.2.0+ install, because the installer should be able to pick up on the existing pe.conf file.
|
Can one of the admins verify this patch? |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
highb
force-pushed
the
feature/pe-15351_non_interactive_flag_on_installer
branch
2 times, most recently
from
9431331 to
7fd9fbf
Compare
|
Refer to this link for build results (access rights to CI server needed): |
Prior to this commit the condition used to decide whether to use the `-c`/`-f` flags was dependent on `host['pe_upgrade_ver']` and `host['pe_ver']` which was an unreliable condition. This commit updates the condition to determine whether to use the `-f` flag to simply look at `host['pe_ver']` because that value is updated depending on what version of pe is currently being installed or upgraded to. The condition to decide to omit the `-c` flag has to depend on `opts[:HOSTS][host.name][:pe_ver]` because that value is not modified during upgrade and can be used for a valid comparison to determine if the install will have a `pe.conf` file to use for an upgrade.
highb
force-pushed
the
feature/pe-15351_non_interactive_flag_on_installer
branch
from
7fd9fbf to
33cdfef
Compare
|
Refer to this link for build results (access rights to CI server needed): |
Prior to this commit I was using the `-f` option in the installer, now it is `-y`. For more information, see https://github.com/puppetlabs/pe-installer-shim/pull/31/commits/0dfd6eb488456a7177673bb720edf9758521f096
|
Refer to this link for build results (access rights to CI server needed): |
highb
changed the title
|
@highb I thought you mentioned a PR that needed synchronization with another repo's changes. Is this that one? |
|
@kevpl Yeah, this PR needs to be merged at the same time as https://github.com/puppetlabs/pe-installer-shim/issues/31 |
|
Since that PR is merged, this should be good to go now. |
Prior to this commit there was not an option for signalling a
non-interactive install to the installer.
This commit adds the new
-foption added inhttps://github.com/puppetlabs/pe-installer-shim/pull/31 to the
command line options for installation/upgrade.
Additionally, this commit will remove the
-cparameter beingpassed on upgrades from a 2016.2.0+ install, because the installer
should be able to pick up on the existing pe.conf file.