Skip to content

Commit

Permalink
(maint) Remove unused variables
Browse files Browse the repository at this point in the history
The version variable is not used in the fetch_pe_on_windows method (and
hopefully wasn't producing a useful side effect...)

The removed snapshot and box keys in HOST_DEFAULTS were being
overwritten by later keys in the same hash definition and were producing
warnings...
  • Loading branch information
jpartlow committed Feb 23, 2017
1 parent 3b0bd45 commit 7dce71c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion lib/beaker-pe/install/pe_utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ def fetch_pe_on_mac(host, opts)
def fetch_pe_on_windows(host, opts)
path = host['pe_dir'] || opts[:pe_dir]
local = File.directory?(path)
version = host['pe_ver'] || opts[:pe_ver_win]
filename = "#{host['dist']}"
extension = ".msi"
if local
Expand Down
2 changes: 0 additions & 2 deletions spec/helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ def fog_file_contents

module HostHelpers
HOST_DEFAULTS = { :platform => 'unix',
:snapshot => 'pe',
:box => 'box_name',
:roles => ['agent'],
:snapshot => 'snap',
:ip => 'default.ip.address',
Expand Down

0 comments on commit 7dce71c

Please sign in to comment.