Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Native Installer script #69

Merged
merged 11 commits into from
Sep 7, 2020
Merged

Conversation

joshpetit
Copy link
Collaborator

I followed the instructions found in #1 and made a script to automate the process. I used the 7z tool too extra the .exe (I'm not sure there's an alternative preinstalled on most systems) so it requires that to be installed, but there is a check at the start to ensure it's on the system.

I also updated the README to indicate these changes.

@Vedaant-Rajoo
Copy link

@puneetsl Kindly merge this request ASAP.

@AkechiShiro
Copy link

Thanks I tested it the script worked for me I'm on PopOS 20.04. This native installing script is only to extract the .exe (and create a shortcut for the Notion native app) so I take it it's not really made for Linux use ?? Or am I wrong ?

@joshpetit
Copy link
Collaborator Author

so I take it it's not really made for Linux use ?? Or am I wrong ?

The script extracts the electron ASAR for windows. It will be just like running the windows notion app but on Linux. There shouldn't be any complications, but you're right, it wasn't made with Linux use in mind.

@AkechiShiro
Copy link

AkechiShiro commented Sep 4, 2020

Okay thanks, so in that case to run the native app the binary to be used is the one contained in the /Lotion folder of the script I suppose.

@puneetsl
Copy link
Owner

puneetsl commented Sep 7, 2020

Hey, thanks for contributing!
And apologies, I was out for the weekend and couldn't take a look at it earlier.
Let me do a quick code review.

.idea/.gitignore Outdated Show resolved Hide resolved
@@ -15,7 +15,7 @@ Terminal=false
Categories=Office;TextEditor;Utility
Type=Application
Icon=${WORKING_DIR}/icon.png
StartupWMClass=Lotion
StartupWMClass=$1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change! thanks

@puneetsl
Copy link
Owner

puneetsl commented Sep 7, 2020

I like the changes, just the .idea folder can be added to .gitignore (or removed from the PR). I'll merge as soon as you make that change.
And I really appreciate the contributions, Thanks a lot

@puneetsl
Copy link
Owner

puneetsl commented Sep 7, 2020

Perfect! Merging

@puneetsl puneetsl merged commit 6e5f245 into puneetsl:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants