-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Native Installer script #69
Conversation
@puneetsl Kindly merge this request ASAP. |
Thanks I tested it the script worked for me I'm on PopOS 20.04. This native installing script is only to extract the .exe (and create a shortcut for the Notion native app) so I take it it's not really made for Linux use ?? Or am I wrong ? |
The script extracts the electron ASAR for windows. It will be just like running the windows notion app but on Linux. There shouldn't be any complications, but you're right, it wasn't made with Linux use in mind. |
Okay thanks, so in that case to run the native app the binary to be used is the one contained in the |
Hey, thanks for contributing! |
@@ -15,7 +15,7 @@ Terminal=false | |||
Categories=Office;TextEditor;Utility | |||
Type=Application | |||
Icon=${WORKING_DIR}/icon.png | |||
StartupWMClass=Lotion | |||
StartupWMClass=$1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome change! thanks
I like the changes, just the |
Perfect! Merging |
I followed the instructions found in #1 and made a script to automate the process. I used the 7z tool too extra the .exe (I'm not sure there's an alternative preinstalled on most systems) so it requires that to be installed, but there is a check at the start to ensure it's on the system.
I also updated the README to indicate these changes.