Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow missing docs when upgrading bridged providers #303

Closed
VenelinMartinov opened this issue Feb 3, 2025 · 0 comments · Fixed by pulumi/ci-mgmt#1379
Closed

Allow missing docs when upgrading bridged providers #303

VenelinMartinov opened this issue Feb 3, 2025 · 0 comments · Fixed by pulumi/ci-mgmt#1379
Assignees
@VenelinMartinov
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

Upstream provider upgrades for bridged providers often fail due to missing documentation upstream from new resources. We should allow this instead of having to manually work around it each time.

Longer discussion: https://docs.google.com/document/d/1MTMSceicK9hrnnIuJ2OyhOktcgIc7EBNENyRFStG27s/edit?tab=t.0
@VenelinMartinov VenelinMartinov added the kind/engineering Work that is not visible to an external user label Feb 3, 2025
@VenelinMartinov VenelinMartinov self-assigned this Feb 3, 2025
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Feb 3, 2025
@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Feb 3, 2025
This was referenced Feb 3, 2025
Closed
Merged
VenelinMartinov added a commit to pulumi/pulumi-upgrade-provider-action that referenced this issue Feb 4, 2025
@VenelinMartinov
Add allow missing docs arg (#37)
ff5cb59 
This will allow us to opt-in Tier 1 providers and opt-out all the rest

Related to pulumi/upgrade-provider#303
@VenelinMartinov VenelinMartinov mentioned this issue Feb 4, 2025
Merged
github-merge-queue bot pushed a commit to pulumi/ci-mgmt that referenced this issue Feb 4, 2025
@VenelinMartinov
Allow missing docs config (#1354)
0365303 
This config will allow us to opt-out Tier 1 providers and opt-in Tier2+
providers.

Currently defaults to False, will flip to True once we opt-out Tier 1
providers.

Related to pulumi/upgrade-provider#303
This was referenced Feb 11, 2025
Merged
Merged
Merged
Merged
Merged
VenelinMartinov added a commit to pulumi/pulumi-azure that referenced this issue Feb 11, 2025
@VenelinMartinov
Disallow missing resource docs on upgrades (#3003)
0cd2d88 
Sets the `allowMissingDocs` ci-mgmt config to false to error on missing
resource docs. This maintains the current behaviour.

Part of pulumi/upgrade-provider#303
@VenelinMartinov VenelinMartinov mentioned this issue Feb 11, 2025
Merged
VenelinMartinov added a commit to pulumi/pulumi-azuread that referenced this issue Feb 11, 2025
@VenelinMartinov
Disallow missing resource docs on upgrades (#1877)
a2164e4 
Sets the `allowMissingDocs` ci-mgmt config to false to error on missing
resource docs. This maintains the current behaviour.

Part of pulumi/upgrade-provider#303
VenelinMartinov added a commit to pulumi/pulumi-azure that referenced this issue Feb 11, 2025
@VenelinMartinov
Disallow missing resource docs on upgrades (#3004)
905c570 
Standing this up again as I accidentally merged
#3003 into the other branch.

Sets the `allowMissingDocs` ci-mgmt config to false to error on missing
resource docs. This maintains the current behaviour.

Part of pulumi/upgrade-provider#303
VenelinMartinov added a commit to pulumi/pulumi-gcp that referenced this issue Feb 11, 2025
@VenelinMartinov
Disallow missing resource docs on upgrades (#2971)
bccfe94 
Sets the `allowMissingDocs` ci-mgmt config to false to error on missing
resource docs. This maintains the current behaviour.

Part of pulumi/upgrade-provider#303
VenelinMartinov added a commit to pulumi/pulumi-aws that referenced this issue Feb 11, 2025
@VenelinMartinov
Disallow missing resource docs on upgrades (#5193)
4bc6f5b 
Sets the `allowMissingDocs` ci-mgmt config to false to error on missing
resource docs. This maintains the current behaviour.

Part of pulumi/upgrade-provider#303
github-merge-queue bot pushed a commit to pulumi/ci-mgmt that referenced this issue Feb 11, 2025
@VenelinMartinov
Allow missing resource docs for Tier2+ providers (#1379)
06f7079 
This PR changes all Tier2+ providers to allow missing resource docs when
running a provider upgrade. This is a common issue which happens and we
have to manually work around.

Fixes pulumi/upgrade-provider#303

Tier 1 providers are exempt as the config is explicitly false there:
pulumi/pulumi-gcp#2971
pulumi/pulumi-aws#5193
pulumi/pulumi-azure#3003
pulumi/pulumi-azuread#1877
github-merge-queue bot pushed a commit to pulumi/ci-mgmt that referenced this issue Feb 12, 2025
@VenelinMartinov
Allow missing resource docs for Tier2+ providers (#1379)
bebe923 
This PR changes all Tier2+ providers to allow missing resource docs when
running a provider upgrade. This is a common issue which happens and we
have to manually work around.

Fixes pulumi/upgrade-provider#303

Tier 1 providers are exempt as the config is explicitly false there:
pulumi/pulumi-gcp#2971
pulumi/pulumi-aws#5193
pulumi/pulumi-azure#3003
pulumi/pulumi-azuread#1877
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Feb 12, 2025
@VenelinMartinov VenelinMartinov mentioned this issue Feb 19, 2025
Merged
github-merge-queue bot pushed a commit to pulumi/ci-mgmt that referenced this issue Feb 19, 2025
@VenelinMartinov
Bump upgrade-provider-action (#1394)
960d5e1 
Thomas spotted some warnings related to some recent changes to
upgrade-provider-action:
https://github.com/pulumi/pulumi-azuredevops/actions/runs/13382459741/job/37373285196

Looks like we never bumped the version of the action so the
`allow-missing-docs` arg was not recognized.

Related to #1379
Related to pulumi/upgrade-provider#303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
2 participants
@VenelinMartinov @pulumi-bot