Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete examples #838

Merged
merged 3 commits into from
Feb 19, 2025
Merged

remove obsolete examples #838

merged 3 commits into from
Feb 19, 2025

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Feb 19, 2025

Proposed changes

Remove the old examples due to:

  1. obsolete operator install instructions
  2. not ported to v2 api (e.g. must have a service account)
  3. walkthrough text is erroneous (e.g. about monitoring the operator pod vs. the workspace pod)

Note that we had a different set of (simpler, newer) examples in operator/examples. Am moving them to the top-level.

Related issues (optional)

@EronWright EronWright requested a review from rquitales February 19, 2025 02:03
@EronWright EronWright added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Feb 19, 2025
@EronWright EronWright merged commit 4fa2c53 into issue-696 Feb 19, 2025
2 checks passed
@EronWright EronWright deleted the issue-696-b branch February 19, 2025 06:03
EronWright added a commit that referenced this pull request Feb 19, 2025
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
    for Pulumi's contribution guidelines.

    Help us merge your changes more quickly by adding more details such
    as labels, milestones, and reviewers.-->

### Proposed changes

<!--Give us a brief description of what you've done and what it solves.
-->
Remove the old examples due to:
1. obsolete operator install instructions
2. not ported to v2 api (e.g. must have a service account)
3. walkthrough text is erroneous (e.g. about monitoring the operator pod
vs. the workspace pod)


Note that we had a different set of (simpler, newer) examples in
`operator/examples`. Am moving them to the top-level.

### Related issues (optional)

<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants