Add ability to resync stacks periodically #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jelsesiy
approved these changes
Dec 12, 2021
lblackstone
approved these changes
Dec 13, 2021
Comment on lines
+265
to
+267
| if sess.stack.ResyncFrequencySeconds != 0 && sess.stack.ResyncFrequencySeconds < 60 { | ||
| resyncFreqSeconds = 60 | ||
| } |
There was a problem hiding this comment.
Any particular reason to set 60 seconds as the minimum? I think it's a reasonable default, but it seems like we could allow users to opt into a shorter interval.
There was a problem hiding this comment.
I am a little concerned about the overhead of having to checkout and then cleanup resources around each sync. There is probably some low-lift caching we can do here but given current use cases 60 seconds seems like an acceptable limit to place for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As mentioned in #242, the change here allows marking stacks as requiring periodic resync. This essentially builds on top branch polling support added in #162 by making the polling frequency configurable with
resyncFrequencySeconds(with the limit that the quickest frequency supported is 60 seconds). By settingcontinueResyncOnCommitMatch- the operator will try a full resync instead of halting if the last known successful commit matches the current commit of the repository.Related issues (optional)
Fixes #242