-
Notifications
You must be signed in to change notification settings - Fork 144
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Your site preview for commit cb45167 is ready! 🎉 http://pulumi-hugo-origin-pr-2944-cb451675.s3-website.us-west-2.amazonaws.com. |
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: susanev <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: susanev <[email protected]>
This comment was marked as duplicate.
This comment was marked as duplicate.
Signed-off-by: susanev <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: susanev <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: susanev <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: susanev <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: susanev <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: susanev <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: susanev <[email protected]>
This comment was marked as duplicate.
This comment was marked as duplicate.
Signed-off-by: susanev <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: susanev <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this looks great! just a couple of comments on some of the JS, but great job with all of this!!
})(document, jQuery); | ||
|
||
function setDocsMainNavPosition() { | ||
if ($(this).width() < 1280) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do these screen size related changes need to be done using javascript? We typically don't do this using javascript and this can make it difficult to reason about when some of the responsive related styling is handled in css and some in javascript. Also, don't need to block on this, we can update this after. Though, if there is a reason this needs to be done this way ignore me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the answer is yes, it needs to be done this way. but half way through building this i realized i could do the open and close nav in css only. but i think that will require more work so id rather do this in another pr though. but id love to zoom and talk it through.
Signed-off-by: susanev <[email protected]>
Your site preview for commit a7dd2a2 is ready! 🎉 http://pulumi-hugo-origin-pr-2944-a7dd2a2f.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀
Description
this is only in docs right now not registry
also, @anita-trimbur how would you feel about saving the hamburger menu for another pr? and leaving the little left-nav tab on mobile until then?
id like to save these items for other prs..
this makes it seem like layout issues but its really content issues, well and @anita-trimbur we need designs for a responsive table in docs
fixes some of pulumi/docs#8988
what this pr does...
Checklist: