Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restart option pulpcore-worker #4685

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Add restart option pulpcore-worker #4685

merged 1 commit into from
Nov 9, 2023

Conversation

mdellweg
Copy link
Member

@mdellweg mdellweg commented Nov 8, 2023

[noissue]

@mdellweg mdellweg marked this pull request as ready for review November 8, 2023 12:46
ipanova
ipanova reviewed Nov 8, 2023
View reviewed changes
CHANGES/+pulpcore-worker-restart.feature
@@ -0,0 +1 @@
Added a ``--restart`` option to pulpcore worker. This requires "hupper" to be installed.
Copy link
Member

@ipanova ipanova Nov 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this new way of adding a record to the changelog? there is no issue filed but you have pulpcore-worker-restart.features?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The + allows you to create an "orphan" changelog entry (or an entry without an issue).

twisted/towncrier#428

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
It's an orphan newsfragment.

@daviddavis
Copy link
Contributor

Is this purely a development feature or is it meant for end users?

@mdellweg
Copy link
Member Author

mdellweg commented Nov 8, 2023

Is this purely a development feature or is it meant for end users?

Development. Restarting in Production should be handled by e.g. the operator.

@mdellweg mdellweg merged commit 3662874 into pulp:main Nov 9, 2023
@mdellweg mdellweg deleted the worker_reload branch November 9, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddavis daviddavis daviddavis left review comments

@dralley dralley dralley approved these changes

@ipanova ipanova ipanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdellweg @daviddavis @dralley @ipanova