Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows you to use arrow keys to open a combobox and navigate within it #4727

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Allows you to use arrow keys to open a combobox and navigate within it #4727

merged 4 commits into from
Jan 29, 2025

Conversation

maxkadel
Copy link
Contributor

  • After you hit enter to select an item, trying to navigate with the arrow keys just scrolls the page

Connected to #4719

maxkadel and others added 4 commits January 24, 2025 14:01
@maxkadel
Test & format changes only
100db8c
@maxkadel
Fix console error - could not link label with field
2b51315
@maxkadel
Does not actually allow you to select
524c156 
You can use the arrow key to go to the first item in the list, but then every time you press it takes you back to the first item in the list
@maxkadel @sandbergja
@carolyncole @christinach
Test for keyboard nav in multiselect combobox
60cbd28 
Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Carolyn Cole <[email protected]>
Co-authored-by: Christina Chortaria <[email protected]>
sandbergja
sandbergja approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxkadel, @christinach , and @carolyncole ! 🦄

@coveralls
Copy link

Coverage Status

coverage: 95.665%. remained the same
when pulling 60cbd28 on i4719_advanced_search_keyboard_navigation
into 6ddf1e4 on main.

@sandbergja sandbergja merged commit 0d78909 into main Jan 29, 2025
15 checks passed
@sandbergja sandbergja deleted the i4719_advanced_search_keyboard_navigation branch January 29, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandbergja sandbergja sandbergja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxkadel @coveralls @sandbergja