Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced form: only process facets that have include_in_advanced_search: true #4680

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

sandbergja
Copy link
Member

Before this commit, the AdvancedSearchFormComponent processed any field in the CatalogController that did not have include_in_advanced_search: false.

In theory, this should not be particularly expensive, but a subtle bug in Blacklight causes some performance issues in cases where we try to process fields that aren't included in the Solr response and when the solr response contains many facet values -- basically the exact situation of our advanced search form! See
projectblacklight/blacklight#3484 and projectblacklight/blacklight#3485 for further details.

…ch: true

Before this commit, the AdvancedSearchFormComponent
processed any field in the CatalogController that did not
have include_in_advanced_search: false.

In theory, this should not be particularly expensive,
but a subtle bug in Blacklight causes some performance
issues in cases where we try to process fields that aren't
included in the Solr response and when the solr response
contains many facet values -- basically the exact situation
of our advanced search form!  See
projectblacklight/blacklight#3484
and projectblacklight/blacklight#3485
for further details.
@coveralls
Copy link

Coverage Status

coverage: 95.815%. remained the same
when pulling a186e39 on advanced-search
into 3a3c75b on main.

@sandbergja sandbergja marked this pull request as ready for review January 6, 2025 20:29
Copy link
Member

@kevinreiss kevinreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandbergja!

Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandbergja !

@christinach christinach merged commit fd931b5 into main Jan 6, 2025
14 checks passed
@christinach christinach deleted the advanced-search branch January 6, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants