Advanced form: only process facets that have include_in_advanced_search: true #4680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the AdvancedSearchFormComponent processed any field in the CatalogController that did not have include_in_advanced_search: false.
In theory, this should not be particularly expensive, but a subtle bug in Blacklight causes some performance issues in cases where we try to process fields that aren't included in the Solr response and when the solr response contains many facet values -- basically the exact situation of our advanced search form! See
projectblacklight/blacklight#3484 and projectblacklight/blacklight#3485 for further details.