Fix broken mean. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magiconair
added a commit
to fabiolb/fabio
that referenced
this pull request
Jan 17, 2017
This patch replaces the github.com/pubnub/go-metrics-statsd library with a patched version which fixes pubnub/go-metrics-statsd#1
'gf' was generating the following error when sending metrics with fabio: KeyError: 'gf'
'gf' -> 'g' for gauge
|
Hey, Thanks for your PR. Merging now. I also just noticed that we used our "--" to seperate the source. This is specific to our statsd configuration (it can be configured to whatever). We could roll this into the specified prefix so rather than specifying the prefix to be "us-west-1" it would be "us-west-1--". |
|
@jshaw86 if that is the case then I think this would be good. However, at this point this is a breaking change. Maybe you can add a @killcity do you have an opinion on this since we're not a statsd/dogstatd user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for fabiolb/fabio#207