-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing css files to assets.rb file #7546
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7546 +/- ##
==========================================
- Coverage 82.02% 81.90% -0.12%
==========================================
Files 97 97
Lines 5612 5615 +3
==========================================
- Hits 4603 4599 -4
- Misses 1009 1016 +7
|
@jywarren @VladimirMikulic can you kindly review this? Thanks ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to place these in application.css
since these are not referenced with stylesheet_link_tag
and are not required to be in this file?
cbe0a03
to
797a9d1
Compare
@VladimirMikulic have moved the files to application.css ..there's only 1 file since remaining are present already in assets.rb and application.css.Can you kindly review? Thanks ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thanks @Tlazypanda for awesome work you've done 🚀
@cesswairimu not sure how to make travis pass 😅 |
We will just restart and restart again 😆..sorry travis can be frustrating |
Screenshots 📸 (click to expand)7546-test_questions.png7546-test_embeddable_grids.png7546-test_signup.png7546-test_viewing_the_settings_page.png7546-test_tag_by_author_page.png7546-failures_test_removing_tags_from_the_post.png7546-test_wiki_page_with_inline_grids.png7546-test_stats.png7546-test_viewing_the_dashboard.png7546-test_searching_an_item_from_the_homepage.png7546-test_signup_modal_form_validation.png7546-test_tag_stats.png7546-test_login_modal_form_validation.png7546-test_questions_shadow.png7546-test_login_modal.png7546-test_profile_page.png7546-test_comments.png7546-test_tags.png7546-test_signup_modal.png7546-test_wiki.png7546-test_methods.png7546-test_tag_page.png7546-test_blog_page_with_location_modal.png7546-test_tag_wildcard.png7546-test_signup_modal_disabled_submit_button_on_empty_username.png7546-test_embeddable_thumbnail_grids.png7546-test_front_page_with_navbar_search_autocomplete.png7546-test_spam_moderation_page.png7546-test_login.png7546-test_viewing_the_dropdown_menu.png7546-test_viewing_question_post.png7546-test_mobile_displays.png7546-failures_test_main_textarea_image_drag_and_drop_upload.png7546-test_simple-data-grapher_powertag.png7546-test_front.png7546-test_question_page.png7546-test_tag_contributors_page.png7546-test_blog.png7546-failures_test_thumbnail_image_drag_and_drop_upload.png7546-test_people.png7546-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
@cesswairimu travis passed this time but codecov failed 😆 😝 |
@cesswairimu travis still failing 😢 can you help me out? 😅 |
@cesswairimu The line 12 of In the test file, we are doing math with "times". Can we rewrite this test to preserve the functionality, but without "time" hacking? @Tlazypanda your view on this? |
@VladimirMikulic @cesswairimu Umm..going through this found these links might be helpful ...can you check it out? Thanks ✌️ |
@Tlazypanda I have restarted travis, the test are all green now. |
Oh wow great catch @VladimirMikulic. Would you be able to open an issue with this insight? |
Awesome! Thanks a lot!!! |
🎉 |
@jywarren I'll open the issue and try to solve this issue once and for all! |
Fixes #7529
rake test
@publiclab/reviewers
for help, in a comment below