invert if/else #11447 (#11449)

publiclab · Sep 30, 2022 · f060bd2 · f060bd2
1 parent df34af2
commit f060bd2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app/controllers/questions_controller.rb b/app/controllers/questions_controller.rb
@@ -9,10 +9,10 @@ def filter_questions_by_tag(questions, tagnames)
       .joins(:tag)
       .where('node.nid IN (?)', nids)
       .group('node.nid')
-    if !tagnames.empty?
-      questions.where('term_data.name IN (?)', tagnames)
-    else
+    if tagnames.empty?
       questions
+    else
+      questions.where('term_data.name IN (?)', tagnames)
     end
   end