Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors, warnings and noise in sample app #7220

Merged
merged 18 commits into from
Dec 24, 2024
Merged

Fix errors, warnings and noise in sample app #7220

merged 18 commits into from
Dec 24, 2024

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Dec 18, 2024 •
edited
Loading

Refs: #7077

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@sdvg sdvg linked an issue Dec 18, 2024 that may be closed by this pull request
Fehler und Debug-Ausgaben aus Sample App Console entfernen #7077
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://676a59e219894b5e907b8db3--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/676a59e219894b5e907b8db3

sdvg and others added 10 commits December 18, 2024 18:35
@sdvg @publicuibot
Update all snapshots$
0b0e96a 
$
Refs: #7077
@sdvg
Fix userActivation property access
f0cf78a 
Refs: #7077
@sdvg
Merge branch '7077-clean-console' of github.com:public-ui/kolibri int…
013d223 
…o 7077-clean-console

* '7077-clean-console' of github.com:public-ui/kolibri:
  Update all snapshots$ $ Refs: #7077
@sdvg
Remove redundant ref props
9fa917a 
Refs: #7077
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 7077-clea…
d9b0a27 
…n-console

* 'develop' of github.com:public-ui/kolibri:
  Update all snapshots$ $ Refs: #7015
  Removed now unused data module
  Remove deprecated component KolTable and rewrite samples to KolTableStateful
  Update docs
  Remove deprecated focus methods
  Remove deprecated component KolLogo
  Remove deprecated component KolLinkGroup
  Remove deprecated component KolIndentedText
  Remove leftover buttonGroup reference
  Remove deprecated component KolButtonGroup
  Fix Husky/ESLint for vaadin.js
@sdvg
Fix faulty imports in Sample App
099fe49 
Refs: #7077
@sdvg
Merge branch 'develop' into 7077-clean-console
bae3890
@sdvg
Fix cross browser navigator.vibrate call
726d6d9 
Refs: #7077
@sdvg
Merge branch 'develop' into 7077-clean-console
393e868
@sdvg
Merge branch 'develop' into 7077-clean-console
be0d7af
@sdvg sdvg marked this pull request as ready for review December 19, 2024 17:09
deleonio
deleonio previously approved these changes Dec 23, 2024
View reviewed changes
@deleonio deleonio merged commit 6947e75 into develop Dec 24, 2024
9 checks passed
@deleonio deleonio deleted the 7077-clean-console branch December 24, 2024 07:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fehler und Debug-Ausgaben aus Sample App Console entfernen
2 participants
@sdvg @deleonio