Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Bug: Hintergrund von Input, Select und Textarea korrigieren #6485

Open
4 tasks done
deleonio opened this issue May 30, 2024 · 4 comments · Fixed by #6884
Open
4 tasks done

🐞 Bug: Hintergrund von Input, Select und Textarea korrigieren #6485

deleonio opened this issue May 30, 2024 · 4 comments · Fixed by #6884
Assignees
@anicyne
Labels
bug Something isn't working intern v2 v3 Here are issues that need to be resolved for version 3.

Comments

@deleonio
Copy link
Contributor

deleonio commented May 30, 2024 •
edited
Loading

Teilweise scheint die Hintergrundfarbe an den Seiten bei den Eingabefeldern durch. Das CSS muss so angepasst werden, dass auch diese fix mit weiß ausgefüllt sind.

  • Anpassung im Basis-Styling der Komponents
  • bei allen Inputs eine Zeile auswählen und Hintergrund am div auf schwarz stellen
  • snapshots neu generieren
  • Bitte später auch alle internen Theme prüfen (KOLIBRI-547)

Änderung: Füge doch bitte beim Ticket #6884 zu jedem Input eine Zeile hinzu, wo wir in der Sample-App eine Zeile mit schwarzen Hintergrund machen, oder wähle eine vorhandene aus.

So werden wir den Fehler dauerhaft sehen und absichern können.

Ich weiß das ändert den Scope, aber ist sinnvoll.

Ticketnummer: KOLIBRI-570
@deleonio deleonio added the bug Something isn't working label May 30, 2024
@deleonio deleonio added the v2 label May 31, 2024
@deleonio deleonio removed the status in KoliBri Board Sep 23, 2024
@deleonio deleonio moved this to 📄 Ready in KoliBri Board Sep 25, 2024
@deleonio deleonio moved this from 📄 Ready to Backlog in KoliBri Board Sep 25, 2024
@anicyne anicyne self-assigned this Sep 26, 2024
@deleonio deleonio moved this from Backlog to 📄 Ready in KoliBri Board Sep 26, 2024
anicyne added a commit that referenced this issue Sep 26, 2024
@anicyne
Adjusted base styling for inputs
47a0e58 
Refs: #6485
@anicyne anicyne mentioned this issue Sep 26, 2024
Merged
@anicyne anicyne linked a pull request Sep 26, 2024 that will close this issue
Fix Background Color for inputs #6884
Merged
@deleonio deleonio moved this from 🔍 Review to 🏗 In progress in KoliBri Board Sep 26, 2024
anicyne added a commit that referenced this issue Sep 26, 2024
@anicyne
Add black background test to inputs
b48c7d5 
Refs: #6485
publicuibot bot pushed a commit that referenced this issue Sep 26, 2024
@anicyne @publicuibot
Update all snapshots$
08d932d 
$
Refs: #6485
deleonio added a commit that referenced this issue Sep 26, 2024
@deleonio
refactor: rename background to background-color / enable always white bg
c9bd304 
Refs: #6485
deleonio added a commit that referenced this issue Sep 26, 2024
@deleonio
chore: optimize packaging
ad5c2cf 
Refs: #6485
deleonio added a commit that referenced this issue Sep 26, 2024
@deleonio
refactor: rename background to background-color / enable always white bg
99339f0 
Refs: #6485
publicuibot bot pushed a commit that referenced this issue Sep 26, 2024
@deleonio @publicuibot
Update all snapshots$
23d8b02 
$
Refs: #6485
deleonio added a commit that referenced this issue Sep 26, 2024
@deleonio
chore: update deps
0d546b4 
Refs: #6485
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in KoliBri Board Sep 26, 2024
@anicyne anicyne reopened this Sep 27, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in KoliBri Board Sep 27, 2024
@deleonio deleonio moved this from ✅ Done to 🏗 In progress in KoliBri Board Sep 27, 2024
@deleonio
Copy link
Contributor Author

@anicyne Die Arbeit kann intern fortgesetzt werden.

sdvg added a commit that referenced this issue Oct 7, 2024
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into feature/6…
5ca4ac4 
…661-git-hooks-precommit

* 'develop' of github.com:public-ui/kolibri: (139 commits)
  Revert "chore: update deps"
  chore: update deps
  Update all snapshots$ $ Refs: #6485
  refactor: rename background to background-color / enable always white bg
  Update all snapshots$ $ Refs: #6485
  Fix delayed display of single-select value
  Add black background test to inputs
  Adjusted base styling for inputs
  Fix lint error
  removed timeout in focusErrorList()
  Added documentation,  described multi-sort functionality, and provided an example in React app.
  lint fix
  added KolSelect to input-group-with-error.tsx
  added input-error mixin
  error-style only when not hide-error is set in Default
  error-style only when not hide-error is set ind Default
  extended known issues text
  extended known issues text
  extended known issues text
  docs: update indented text readme
  ...
sdvg added a commit that referenced this issue Oct 9, 2024
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 6138-auto…
e2d6884 
…-alert

* 'develop' of github.com:public-ui/kolibri: (149 commits)
  chore: release 2.1.9-rc.0
  Remove unecessary array fallback
  Update all snapshots$ $ Refs: #6159
  fix format
  Revert "Update all snapshots$"
  Update all snapshots$ $ Refs: #6159
  table head and foot spacer
  Revert "chore: update deps"
  Fix combobox shows empty list on navigation
  chore: update deps
  Update all snapshots$ $ Refs: #6485
  refactor: rename background to background-color / enable always white bg
  Update all snapshots$ $ Refs: #6485
  Fix delayed display of single-select value
  Add black background test to inputs
  Adjusted base styling for inputs
  Fix lint error
  removed timeout in focusErrorList()
  Added documentation,  described multi-sort functionality, and provided an example in React app.
  lint fix
  ...
@anicyne
Copy link
Contributor

anicyne commented Oct 10, 2024

Blockiert bis #6923 erledigt ist

sdvg added a commit that referenced this issue Oct 11, 2024
@sdvg
Merge branch '6138-auto-alert' of github.com:public-ui/kolibri into f…
9688bc8 
…ix/clean-code-by-arch-pattern

* '6138-auto-alert' of github.com:public-ui/kolibri: (170 commits)
  chore: release 2.1.9-rc.0
  Remove unecessary array fallback
  Update all snapshots$ $ Refs: #6159
  fix format
  Revert "Update all snapshots$"
  Update all snapshots$ $ Refs: #6159
  table head and foot spacer
  Revert "chore: update deps"
  Fix combobox shows empty list on navigation
  chore: update deps
  Update all snapshots$ $ Refs: #6485
  refactor: rename background to background-color / enable always white bg
  Update all snapshots$ $ Refs: #6485
  Fix delayed display of single-select value
  Add black background test to inputs
  Adjusted base styling for inputs
  Fix lint error
  removed timeout in focusErrorList()
  Added documentation,  described multi-sort functionality, and provided an example in React app.
  lint fix
  ...
@anicyne
Copy link
Contributor

anicyne commented Oct 14, 2024

ich habe Root-Fontsize in den DevTools rausgenommen und alle internen Themes überprüft. Alles sieht korrekt aus.

@anicyne
Copy link
Contributor

anicyne commented Oct 18, 2024

Benötigt #6923

@deleonio deleonio added the v3 Here are issues that need to be resolved for version 3. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anicyne anicyne

Labels
bug Something isn't working intern v2 v3 Here are issues that need to be resolved for version 3.
Projects
KoliBri Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Background Color for inputs public-ui/kolibri
2 participants
@deleonio @anicyne