Skip to content

Commit

Permalink
Remove _tabindex from components with delegatesFocus (#7413)
Browse files Browse the repository at this point in the history
  • Loading branch information
laske185 authored Feb 27, 2025
2 parents e075c4d + 336bddf commit 2ac88b7
Show file tree
Hide file tree
Showing 32 changed files with 0 additions and 186 deletions.
6 changes: 0 additions & 6 deletions packages/components/src/components/button-link/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export class KolButtonLink implements ButtonLinkProps, FocusableElement {
_role="link"
_shortKey={this._shortKey}
_syncValueBySelector={this._syncValueBySelector}
_tabIndex={this._tabIndex}
_tooltipAlign={this._tooltipAlign}
_type={this._type}
_value={this._value}
Expand Down Expand Up @@ -157,11 +156,6 @@ export class KolButtonLink implements ButtonLinkProps, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down
6 changes: 0 additions & 6 deletions packages/components/src/components/button/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export class KolButton implements ButtonProps, FocusableElement {
_role={this._role}
_shortKey={this._shortKey}
_syncValueBySelector={this._syncValueBySelector}
_tabIndex={this._tabIndex}
_tooltipAlign={this._tooltipAlign}
_type={this._type}
_value={this._value}
Expand Down Expand Up @@ -161,11 +160,6 @@ export class KolButton implements ButtonProps, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/combobox/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -425,11 +425,6 @@ export class KolCombobox implements ComboboxAPI {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -547,11 +542,6 @@ export class KolCombobox implements ComboboxAPI {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/input-checkbox/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,6 @@ export class KolInputCheckbox implements InputCheckboxAPI, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -368,11 +363,6 @@ export class KolInputCheckbox implements InputCheckboxAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/input-color/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -193,11 +193,6 @@ export class KolInputColor implements InputColorAPI, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -312,11 +307,6 @@ export class KolInputColor implements InputColorAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/input-date/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,6 @@ export class KolInputDate implements InputDateAPI, FocusableElement {
*/
@Prop() public _step?: number;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -428,11 +423,6 @@ export class KolInputDate implements InputDateAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
11 changes: 0 additions & 11 deletions packages/components/src/components/input-email/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,6 @@ export class KolInputEmail implements InputEmailAPI, FocusableElement {
* @internal
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -402,11 +396,6 @@ export class KolInputEmail implements InputEmailAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/input-file/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -193,11 +193,6 @@ export class KolInputFile implements InputFileAPI, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -310,11 +305,6 @@ export class KolInputFile implements InputFileAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/input-number/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -235,11 +235,6 @@ export class KolInputNumber implements InputNumberAPI, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -385,11 +380,6 @@ export class KolInputNumber implements InputNumberAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/input-password/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -258,11 +258,6 @@ export class KolInputPassword implements InputPasswordAPI, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -416,11 +411,6 @@ export class KolInputPassword implements InputPasswordAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/input-radio/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,6 @@ export class KolInputRadio implements InputRadioAPI, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -357,11 +352,6 @@ export class KolInputRadio implements InputRadioAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/input-range/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,6 @@ export class KolInputRange implements InputRangeAPI, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -411,11 +406,6 @@ export class KolInputRange implements InputRangeAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/input-text/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,6 @@ export class KolInputText implements InputTextAPI, FocusableElement {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -426,11 +421,6 @@ export class KolInputText implements InputTextAPI, FocusableElement {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
6 changes: 0 additions & 6 deletions packages/components/src/components/link-button/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export class KolLinkButton implements LinkButtonProps, FocusableElement {
_on={this._on}
_role="button"
_shortKey={this._shortKey}
_tabIndex={this._tabIndex}
_target={this._target}
_tooltipAlign={this._tooltipAlign}
_variant={this._variant}
Expand Down Expand Up @@ -135,11 +134,6 @@ export class KolLinkButton implements LinkButtonProps, FocusableElement {
*/
@Prop() public _shortKey?: ShortKeyPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to open the link.
*/
Expand Down
6 changes: 0 additions & 6 deletions packages/components/src/components/link/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ export class KolLink implements LinkProps, FocusableElement {
_on={this._on}
_role={this._role}
_shortKey={this._shortKey}
_tabIndex={this._tabIndex}
_target={this._target}
_tooltipAlign={this._tooltipAlign}
>
Expand Down Expand Up @@ -131,11 +130,6 @@ export class KolLink implements LinkProps, FocusableElement {
*/
@Prop() public _shortKey?: ShortKeyPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to open the link.
*/
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/components/single-select/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -488,11 +488,6 @@ export class KolSingleSelect implements SingleSelectAPI {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down Expand Up @@ -608,11 +603,6 @@ export class KolSingleSelect implements SingleSelectAPI {
this.controller.validateSyncValueBySelector(value);
}

@Watch('_tabIndex')
public validateTabIndex(value?: number): void {
this.controller.validateTabIndex(value);
}

@Watch('_touched')
public validateTouched(value?: boolean): void {
this.controller.validateTouched(value);
Expand Down
6 changes: 0 additions & 6 deletions packages/components/src/components/split-button/shadow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ export class KolSplitButton implements SplitButtonProps /*, SplitButtonAPI*/ {
_on={this.clickButtonHandler}
_role={this._role}
_syncValueBySelector={this._syncValueBySelector}
_tabIndex={this._tabIndex}
_tooltipAlign={this._tooltipAlign}
_type={this._type}
_value={this._value}
Expand Down Expand Up @@ -181,11 +180,6 @@ export class KolSplitButton implements SplitButtonProps /*, SplitButtonAPI*/ {
*/
@Prop() public _syncValueBySelector?: SyncValueBySelectorPropType;

/**
* Defines which tab-index the primary element of the component has. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)
*/
@Prop() public _tabIndex?: number;

/**
* Defines where to show the Tooltip preferably: top, right, bottom or left.
*/
Expand Down
Loading

0 comments on commit 2ac88b7

Please sign in to comment.