Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cargo workspace feature #89

Merged
merged 8 commits into from Oct 25, 2022
Merged

Use cargo workspace feature #89

merged 8 commits into from Oct 25, 2022

Conversation

larry0x
Copy link
Collaborator

@larry0x larry0x commented Oct 19, 2022 •
edited
Loading

Use Rust 1.64's new cargo workspace feature to manage package info and dependencies.

NOTES:

  • Currently CI fails because there is a clippy warning, which is out-of-scope for this PR. This is fixed by Fix a clippy warning #92
  • Since the workspace feature is only available at Rust >=1.64.0, adopting this change means all contributors to this repo must update their Rust installation to minimally 1.64.0
  • The bash script scripts/set_version.sh is kinda useless after this PR

@larry0x larry0x marked this pull request as ready for review October 19, 2022 22:16
shanev
shanev approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@shanev shanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed this badly! Thank you @larry0x!

@JakeHartnell JakeHartnell merged commit 90435af into public-awesome:main Oct 25, 2022
@JakeHartnell JakeHartnell mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanev shanev shanev approved these changes

@JakeHartnell JakeHartnell JakeHartnell approved these changes

@0xekez 0xekez Awaiting requested review from 0xekez

@webmaster128 webmaster128 Awaiting requested review from webmaster128

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larry0x @shanev @JakeHartnell