Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cw721-fixed-price] Fix receiving cw20 msg #49

Merged
merged 4 commits into from
Jul 18, 2022
Merged

[cw721-fixed-price] Fix receiving cw20 msg #49

merged 4 commits into from
Jul 18, 2022

Conversation

axvn
Copy link
Contributor

@axvn axvn commented Feb 6, 2022

Cw721-fixed-price contract raise deserialization exception on receiving cw20 tokens, because the message received is wrapped in receive {..}, not cw20_receive_msg {..}

Cw20ReceiveMsg should be de/serialized under Receive() variant in a ExecuteMsg

Ref

JakeHartnell
JakeHartnell approved these changes Jul 17, 2022
View reviewed changes
Copy link
Collaborator

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this fixed, thanks for the PR!

@JakeHartnell JakeHartnell mentioned this pull request Jul 17, 2022
Closed
orkunkl
orkunkl approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@orkunkl orkunkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@orkunkl orkunkl merged commit ce3e581 into public-awesome:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeHartnell JakeHartnell JakeHartnell approved these changes

@orkunkl orkunkl orkunkl approved these changes

@ben2x4 ben2x4 Awaiting requested review from ben2x4

@the-frey the-frey Awaiting requested review from the-frey

@yubrew yubrew Awaiting requested review from yubrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axvn @JakeHartnell @orkunkl