v0.17 upgrade logic #112
v0.17 upgrade logic #112
Conversation
|
@larry0x sorry for being so slow to review. should be able to rebase on main and merge this. |
| # FIXME: change back to the "official" crates.io release after this PR is merged: | ||
| # https://github.com/CosmWasm/cw-plus/pull/858 | ||
| cw2 = { git = "https://github.com/mars-protocol/cw-plus", rev = "1a3a944" } |
There was a problem hiding this comment.
Seems to be an overkill just to get the assert_contract_version helper: https://github.com/CosmWasm/cw-plus/pull/858/files#diff-a35715fa1fde56c42db0d8f2845ebc6a571a801699c0705f0080237820d96ee6R59-R83
Would suggest just to just put it in this contract until we have an "official" version of it.
There was a problem hiding this comment.
@Art3miX My PR to cw2 referenced in the comment has been merged. Now we can use the main branch of cw2 instead of mars-protocol fork. Imo this is more elegant than including extra code in this repo which we need to remove later.
There was a problem hiding this comment.
Oh ok, so this can be changed to the official cw2 now?
I just didn't like the using some fork for a helper function just to revert back later to the previous package.
There was a problem hiding this comment.
We can change it to the main branch (use the latest commit) of the official cw-plus repo
upgrades/v0_16.rstoupgrades/v0_17.rs(I think the filename should be the version being migrated to, not the version being migrated from)cw2::assert_contract_version; have to use our fork of cw2 before our PR is merged)